GetPageSpeed / nginx-extras

Submit your NGINX module for build in GetPageSpeed extras RPM repository
https://www.getpagespeed.com/nginx-extras
BSD 2-Clause "Simplified" License
10 stars 5 forks source link

add mailru graphite module #12

Closed iamstarkov closed 4 years ago

iamstarkov commented 4 years ago

very well maybe

dvershinin commented 4 years ago

Can you update your pull request with the correct soname, then I will merge it.

On Mar 16 2020, at 5:05 pm, Vladimir Starkov notifications@github.com wrote:

very well maybe

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/GetPageSpeed/nginx-extras/pull/12#issuecomment-599554275", "url": "https://github.com/GetPageSpeed/nginx-extras/pull/12#issuecomment-599554275", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

iamstarkov commented 4 years ago

@dvershinin fixed

iamstarkov commented 2 years ago

@dvershinin how do I go about this support for 1.22.0? do I file change in this repo or in https://github.com/mailru/graphite-nginx-module

latest getpagespeed-extras-release/nginx-module-graphite requires nginx-1.20.2 and installation fails when you try to install it

$ yum deplist nginx-module-graphite
Loaded plugins: fastestmirror, getpagespeed, pulp-profile-update
Loading mirror speeds from cached hostfile
package: nginx-module-graphite.x86_64 1:1.20.2+3.1-1.el7.gps
  dependency: /bin/sh
   provider: bash.x86_64 4.2.46-34.el7
  dependency: getpagespeed-extras-release
   provider: getpagespeed-extras-release.noarch 1:11-30
  dependency: libc.so.6(GLIBC_2.14)(64bit)
   provider: glibc.x86_64 2.17-317.el7
  dependency: nginx-r1.20.2
   provider: nginx.x86_64 1:1.20.2-24.el7.ngx
  dependency: rtld(GNU_HASH)
   provider: glibc.x86_64 2.17-317.el7
   provider: glibc.i686 2.17-317.el7
iamstarkov commented 2 years ago

automatic rebuilds against newly released NGINX versions

does this line mean to take care of the problem I stumbled upon?

dvershinin commented 2 years ago

Interesting. Your metadata seems out of date. Because the corresponding module version has already been pushed to repos days ago. See https://extras.getpagespeed.com/redhat/7/x86_64/repoview/nginx-module-graphite.html

Or there's a versionlock?

iamstarkov commented 2 years ago

@dvershinin hmm, interesting. let me check

iamstarkov commented 2 years ago

@dvershinin thank you, it was the billing issue and is fixed now. On this note, do you have a dedicated support communication means mail/slack/discord/etc?

dvershinin commented 2 years ago

@iamstarkov you can always email at info at getpagespeed dot com.