GetPoplog / Seed

Scripts for getting Poplog onto your Linux machine
MIT License
8 stars 3 forks source link

Fix popvision mlp #108

Closed willprice closed 3 years ago

willprice commented 3 years ago

Before fix:

Setpop
: uses popvision;
: uses mlp;

;;; MISHAP - idw: ILLEGAL DECLARATION OF WORD (missing ; after lvars?)
;;; INVOLVING:  ushortvec_key
;;; FILE     :  /usr/local/poplog/V16/pop/packages/lib/../popvision/lib/mlp.p
;;;       LINE NUMBER:  93
;;; PRINT DOING
;;; DOING    :  defclass section loadlib do_load uses_lib_idents pop_setpop_co
;;;     mpiler

After fix:

Setpop
: uses popvision;
: uses mlp;
:
sfkleach commented 3 years ago

Previous comment was incorrect! I misread the change.

sfkleach commented 3 years ago

I am reluctantly accepting this change - reluctant because we're not in control of the sources we are patching and the sources seem to have some active change. BUT it is definitely an improvement. I do think we should hold off a little bit on doing any corrections on this stuff.