GetPoplog / Seed

Scripts for getting Poplog onto your Linux machine
MIT License
8 stars 3 forks source link

Change from poparray_by_row to poparray_by_column #143

Open sfkleach opened 1 month ago

sfkleach commented 1 month ago

Check with Waldek re idea behind

https://github.com/hebisch/poplog/commit/e6cbbaa8b878b6d0598709bcccb6c9b2c67edf33#diff-99d7b5f282acb3487a8eac2d397f087fa19e2fd49585afb5351ca07ed517675d

Isn't this a breaking change?

hebisch commented 1 month ago

On Sun, Oct 06, 2024 at 06:44:55AM -0700, Stephen Leach wrote:

Check with Waldek re idea behind

https://github.com/hebisch/poplog/commit/e6cbbaa8b878b6d0598709bcccb6c9b2c67edf33#diff-99d7b5f282acb3487a8eac2d397f087fa19e2fd49585afb5351ca07ed517675d

Isn't this a breaking change?

Strictly speaking it is. However, impact is quite low:

Alternative would be to keep old definitions as "compatibility layer". IMO such "compatibility layer" would simply delay needed changes with no gain. Of course, if there were real Poplog users needing to run affected code both with old and new Poplog versions, then compatibility definitions would be appropriate. But I do not think such users exist.

-- Waldek Hebisch