search

GetPublii / Publii

The most intuitive Static Site CMS designed for SEO-optimized and privacy-focused websites.
https://getpublii.com
GNU General Public License v3.0
6.06k stars 407 forks source link

[Feature Request]: Ability to activate a lightbox for featured images #1304

Closed Kalistia closed 6 months ago

Kalistia commented 6 months ago

Feature Description

It would be really nice to have the option to activate or not a lightbox view for the featured images on the articles

atomGit commented 6 months ago

...or any single image for that matter

bobmitro commented 6 months ago

I'm closing this topic because it's more relevant to a Publii plugin rather than the core functionality of Publii itself.

atomGit commented 6 months ago

you have an album feature and the code to support it - why would providing lightbox functionality for single images not be handled by the very same code?

Kalistia commented 6 months ago

Thanks Bob for the follow-up!

Could you explain why you think it should be an extension? Because I don't agree, as it's imo a pretty useful thing to have in the basic website builder!

On 12 December 2023 06:36:28 CET, atomGit @.***> wrote:

you have an album feature and the code to support it - why would providing lightbox functionality for single images not be handled by the very same code?

-- Reply to this email directly or view it on GitHub: https://github.com/GetPublii/Publii/issues/1304#issuecomment-1851332876 You are receiving this because you authored the thread.

Message ID: @.***>

bobmitro commented 6 months ago

The lightbox requires CSS and JavaScript, which must be attached to your site. In the Gallery, despite the UI delivered with Publii, the scripts are provided by the theme, not the app.

The lightbox in my option should work automatically; when the user clicks the image, the script should detect this image and display the original (big) image in the popup. The best for that will be a plugin that will catch the pictures and display them in the Lightbox.

Not everyone requires this feature, so it's unnecessary to clutter the interface overly. Incorporating every user-requested option could result in an excessively crowded interface.

Also, a plugin will be easier to maintain and update.

dziudek commented 6 months ago

Definitely - decoupling lightbox mechanism from Publii is a good solution. When we will add this, then there will be people who wants other script/effect etc. It should be solved on the theme/plugin level

Kalistia commented 6 months ago

Thanks guys, that makes more sense to me now :)