GetPublii / Publii

The most intuitive Static Site CMS designed for SEO-optimized and privacy-focused websites.
https://getpublii.com
GNU General Public License v3.0
6.06k stars 407 forks source link

[Bug]: Publii 0.44.2 show error when restore backup #1310

Closed Cineray closed 6 months ago

Cineray commented 6 months ago

Operating system

Windows 11

Publii version

0.44.2

Post editor

None

Bug description

image

0.43.* and 0.44.1 have no such problem.

I can not restore any of my backup in this version, not even new created one.

btw, "Backup" is fine, only "Restore"

Steps to reproduce

No response

Relevant log output

No response

Cineray commented 6 months ago

As long as i click restore button, the Tag menu would shown same error in order to whole software crash.

dziudek commented 6 months ago

Hi @Cineray ,

Thank you for finding this bug - it will be fixed tomorrow in v.0.44.3

As a workaround - after backup restore, please just close app and open again. The restore process still works, but code responsible for closing DB connection was invalid after changing SQLite library what caused this issue

Cineray commented 6 months ago

Hi,

May i ask why remove restore function in backup page?

That is really helpful especially when i sync everything on different OS or environment.

I really hope it back asap.

Thank you

bobmitro commented 6 months ago

We had to temporarily disable this function on Windows due to a specific issue with the database library (node-sqlite3-wasm) that we're using.

The problem, identified only on Windows 11, involves the library not correctly closing the database connection. This issue is exclusive to Windows; it wasn't observed on macOS or Linux. Our efforts to resolve this, including custom builds and adjustments in the close functions, have not yet been successful. This led us to temporarily remove the direct backup restoration option for Windows versions while it remains available for macOS and Linux.

Windows users can still restore the backup using the "Install from Backup" feature on the "Add New Website" screen which is detailed described here: https://getpublii.com/docs/creating-your-website.html#creatingasitefromabackup

Additionally, we have informed the author of the node-sqlite3-wasm library about this issue, and we are actively working with them to find a resolution. We are committed to resolving this issue and hope to reinstate the direct restore function for Windows as soon as possible.

bobmitro commented 6 months ago

We've fixed the issue and brought back the restore function for Windows in our latest update (version 0.44.4 hotfix).

Cineray commented 6 months ago

We've fixed the issue and brought back the restore function for Windows in our latest update (version 0.44.4 hotfix).

Coooool, Great job!