search

GetPublii / Publii

The most intuitive Static Site CMS designed for SEO-optimized and privacy-focused websites.
https://getpublii.com
GNU General Public License v3.0
6.36k stars 419 forks source link

[Bug]: Feather icons 1.2.0 viewBox production / author field #1373

Closed HowToMeetLadies closed 9 months ago

HowToMeetLadies commented 9 months ago

Operating system

macOS

Publii version

0.44.4

Post editor

None

Bug description

The plugin doesn't output a ViewBox for me. Without this information, the symbols will not be rescaled in production (Safari). Why exactly is this property only added in preview mode? Or what am I doing wrong?

I patched the plugin to output viewBox and the icons were scaled correctly.

The “Plugin Author” field is still “Your Name”.

Steps to reproduce

Version 0.44.4 Feather icons 1.2.0, defaults/internal Terminal theme [fi=award size=256px]

Relevant log output

No response

HowToMeetLadies commented 9 months ago

I removed the plugin and reinstalled it (from the same ZIP file) and it still doesn't output a viewBox. But Safari now displays the icon correctly. nm

Safari criticizes the use of "rem":

rembrandt

Many thanks to the team at Publii - Feather is such a great collection.