GetPublii / theme-Starter

Starter theme for Publii theme developers
MIT License
90 stars 24 forks source link

Hero height not working #10

Open SebastianSolidwork opened 5 years ago

SebastianSolidwork commented 5 years ago

I changed Hero height from "29rem" to "2rem" and text to "bar" with no image.

Actual result:

The Hero section stays the same size

from my actual site's css

.hero {
    min-height: 2rem;
}

.hero {
    height: 29rem;
    position: relative;
} 

Additional information

If i change the value in the main.css directly, it get's changed.

Expected result:

The Hero section should become smaller.

Implementation idea

in main.css change height to max-height, so it adopts to the size of the content Maybe adding a input field for that.

SebastianSolidwork commented 5 years ago

I see the options here under Custom Settings: https://getpublii.com/docs/theme-settings.html#js-header It's not like that in the actual application . What happen here? Is it a different theme?