search

GetRD / academic-file-converter

📚 Import Bibtex publications and Jupyter Notebook blog posts into your Markdown website or book. 将Bibtex转换为Markdown网站
https://docs.hugoblox.com/reference/content-types/#automatically-import-publications-from-bibtex
MIT License
356 stars 101 forks source link

Download Much More Assets #57

Closed danielschemmel closed 4 years ago

danielschemmel commented 4 years ago

This PR adds downloading of assets for:

Requires hugo-academic PR 1554 to be merged into the theme.

fixes #14 improves #15: MathJax works, but I do not use reveal (yet?)

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had any recent activity. The resources of the Academic team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please tell us why. This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

Harvester57 commented 4 years ago

I support this PR. Currently, and out-of-the-box (with a fresh pip3 install), importing assets will only import main.min.css and main.min.js,thus breaking the rendering (at least with local hugo server --watch)

gcushen commented 4 years ago

Since the offline asset pipeline in this Python package was initially created, Academic has evolved to using the industry standard Node JS approach to downloading offline assets - see comment at https://github.com/gcushen/hugo-academic/pull/1554#issuecomment-596151573 .

At the time of writing, Bootstrap and the speaker notes tool are the only built-in offline assets.

Hence, please consider opening a PR on the Academic repo to improve handling of offline assets in https://github.com/gcushen/hugo-academic/blob/master/package.json and https://github.com/gcushen/hugo-academic/blob/master/scripts/update_bootstrap.sh .

Ideally, we would attempt to integrate the Node JS approach to offline files closely with the Academic online CDN approach, whether that be using Academic's existing Assets Library or refactoring Academic to attempt to grab the versioning of CDN assets from the package.json. A potential issue with the latter is that the CDN package naming and version naming/availability can differ to that in the NPM Package Registry.

As a result of the above effort, our early Python-based approach to downloading assets will likely be deprecated once offline support has migrated to the Node JS approach.