search

GetRD / academic-file-converter

📚 Import Bibtex publications and Jupyter Notebook blog posts into your Markdown website or book. 将Bibtex转换为Markdown网站
https://docs.hugoblox.com/reference/content-types/#automatically-import-publications-from-bibtex
MIT License
356 stars 101 forks source link

Add support for more bibtex types #67

Closed arichardson closed 4 years ago

arichardson commented 4 years ago

This adds @thesis,@report and @conference as well as tests for the type field.

gcushen commented 4 years ago

@arichardson thanks for your contribution.

68 has just been merged and there are now Git conflicts with your PR.

Please can you consider taking a look at the changes made in #68 and refactoring?

arichardson commented 4 years ago

Sure will do shortly. Looks like I made similar frontmatter changes (using toml instead of yaml) in my local changes: https://github.com/arichardson/academic-admin/tree/my-changes

I'll also try and rebase those other changes.

arichardson commented 4 years ago

Rebased now. Will add another PR with my other changes shortly.

gcushen commented 4 years ago

@arichardson please can you confirm if this PR works without a Docker compose file present?

There are reports in #69 of a possible bug introduced by the recently merged PR #68 ...

arichardson commented 4 years ago

@gcushen yes, this PR works but I encountered the same bug and it should be fixed by https://github.com/arichardson/academic-admin/commit/ff113084bcf4f78aa7b0dba28e92b43dd2323a78 which I haven't pushed as a pr yet. Maybe you could cherry-pick that commit to fix the docker issue?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had any recent activity. The resources of the Academic team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please tell us why. This issue will automatically close soon if no further activity occurs. Thank you for your contributions.