When Adding a new network, we need to strip the `http://` prefix or show an error

GetScatter / ScatterWebExtension

Extension that allows you to sign transactions with your private keys securely from within the browser without ever exposing them.

MIT License

366 stars 127 forks source link

When Adding a new network, we need to strip the `http://` prefix or show an error #115

Open lucca65 opened 6 years ago

lucca65 commented 6 years ago

To avoid problems like this:

nsjames commented 6 years ago

Looking at this now, i'm not sure how you even got those in there. https://github.com/EOSEssentials/Scatter/blob/master/src/views/NetworkView.vue#L60

It should have stripped the http:// off when you input it.

lucca65 commented 6 years ago

Yeah, probably thats because I'm adding the network from javascript using the suggested settings:

const network = {
  blockchain: 'eos',
  host: 'http://dev.cryptolions.io',
  port: 38888
};

Probably it doesn't go through Vue's logic

nsjames commented 6 years ago

Oh. That explains it :) I'll fix that with an error message about not using protocols within the network since there's a protocol field on the network itself.