GetScatter / ScatterWebExtension

Extension that allows you to sign transactions with your private keys securely from within the browser without ever exposing them.
MIT License
366 stars 127 forks source link

[Copy] Export description needs updating now that private keys are exported #116

Closed Soleone closed 6 years ago

Soleone commented 6 years ago

Telegram user @Fow noted that the following is now incorrect:

image

The copy should be updated in the english version and other languages.

Sidenote: A good time to think about how to handle updating of existing translation strings. Somehow the original translators should be made aware that an update to a certain region is required.

nsjames commented 6 years ago

611ad9ee9e7c2230c8bea5233351c3a8501ca9af

nsjames commented 6 years ago

Sidenote: A good time to think about how to handle updating of existing translation strings. Somehow the original translators should be made aware that an update to a certain region is required.

Indeed. At first I was reluctant to add new features or change things because of updates to localization. I quickly let go of that fear, and now there is a lot of changes in the English translation file as well as new keys which don't match/exist in other translations.

Perhaps some kind of diff tool that checks the last commit of a language against changes to the english from that timestamp.

That should probably be a new ticket.