Allow text-2.0 - Githubissues

GetShopTV / swagger2

Swagger 2.0 data model.

http://hackage.haskell.org/package/swagger2

BSD 3-Clause "New" or "Revised" License

74 stars 59 forks source link

Allow text-2.0 #234

Closed ysangkok closed 2 years ago

ysangkok commented 2 years ago

Sadly the doctests fail because the ordering of the required keys changes with text-2.0. I don't know the source so well, so I havn't attempted fixing this.

Fails:

cabal test --constraint='text>=2' -w ghc-9.0.2

Passes:

cabal test --constraint='text<2' -w ghc-9.0.2

Thanks for your work!

swamp-agr commented 2 years ago

@ysangkok,

the reason why tests failed on text-2.0 is in the hashable package.
instance Hashable Text changed, see here for more details: https://github.com/haskell-unordered-containers/hashable/pull/234/files.
And in swagger2 we're relying on HashMap or some variant of it which requires Hashable.

Could you please include CPP wrapper around failing doctests to support MIN_VERSION_text(2,0,0)?

The diff could be obtained from doctests results.

ysangkok commented 2 years ago

@swamp-agr I added the CPP as suggested.

swamp-agr commented 2 years ago

Thanks @ysangkok! I will make a minor release later today.

swamp-agr commented 2 years ago

swagger2-2.8.2 was released on Hackage: https://hackage.haskell.org/package/swagger2-2.8.2