search

GetSimpleCMS / GetSimpleCMS

GetSimple CMS
http://get-simple.info
GNU General Public License v3.0
392 stars 114 forks source link

Allow translators to select position of count variable in "total" strings #162

Closed n00dles closed 11 years ago

n00dles commented 11 years ago

Original author: jos...@gmail.com (March 15, 2011 12:05:53)

In some languages translations would be more natural if GetSimple would allow to change position of count variable in "total" strings, e.g. "%s total files". I made a patch for archives and files values, but stuck on pages and backups - pagination plugin is being used there, and I do not know any better way, except including <span id="pg_counter"> in translation, which is unacceptable. It would be great if this issue is solved before 3.0 release.

Original issue: http://code.google.com/p/get-simple-cms/issues/detail?id=162

n00dles commented 11 years ago

From ccagle8 on March 15, 2011 13:00:26 it would, but there are so many translations out there that are already accounting for this that making the change now would break every old translation coming before it...

n00dles commented 11 years ago

From jos...@gmail.com on March 15, 2011 13:08:00 Yes, I am aware of that, but this might be the best time to make such a drastic change, later introduction of such modification might be even harder. Of course, we would need to figure out how to solve the pagination first.

n00dles commented 11 years ago

From ccagle8 on March 15, 2011 13:15:18 How has other translators handled this up until now? Also, this can't be the only string that is setup this way either...

I think if the translators are creative enough, they can find a way around the couple original strings that were setup not using sprintf. Going forward we have been using sprinf everywhere it makes sense to

n00dles commented 11 years ago

From ccagle8 on March 15, 2011 13:31:49 On top of that, I think we should freeze the language files for 3.0 now anyway. We need to give translators at least a week in order to make their updates/changes - and this would just add to it because we still need to figure out a solution since it's not exactly a cut-and-dry situation.

n00dles commented 11 years ago

From jos...@gmail.com on March 15, 2011 13:44:30 OK, I agree on language file freeze. Let's leave this issue for later.

n00dles commented 11 years ago

From jos...@gmail.com on March 15, 2011 13:44:30 OK, I agree on language file freeze. Let's leave this issue for later.

n00dles commented 11 years ago

From m...@digimute.com on March 15, 2011 14:22:12 FYI: I added 1 change to the language file yesterday "PERMS" for the file permissions.

n00dles commented 11 years ago

From ccagle8 on March 15, 2011 14:39:57 I saw that, but since it's hidden until people turn on DEBUGGING, im willing to not care if the couple translation files created yesterday dont have it. Side note: i wonder if we should make that debug info show something like this: owner/mode. Since ownership caused problems with the file upload, knowing the owner of the file would be great as well.

If it works, maybe we could expand that debug info to pages.php as well.

n00dles commented 11 years ago

From jos...@gmail.com on March 15, 2011 14:48:54 Yes, having owner displayed would really help to debug current filebrowser issue.

n00dles commented 11 years ago

From ccagle8 on March 15, 2011 15:09:39 i agree. I will add it an an enhancement. Doesn't have to be for this release, but i think it will enhance the debugging we will be able to do.

Also: I'm closing this as I don't think we need to translate this string. If later on we decide to fix this, then there will be plenty of other strings that need fixing as well. (there have been a couple publicly complained about in the forums over the months)