search

GetStream / react-native-activity-feed

Official React Native SDK for Activity Feeds
https://getstream.io/
200 stars 87 forks source link

Uncaught Error: ViewPropTypes has been removed from React Native #295

Open danjayrose opened 2 years ago

danjayrose commented 2 years ago

Describe the bug When installing with the latest React Native version this package causes an uncaught error as it uses ViewPropTypes which have been deprecated by React Native.

To Reproduce Steps to reproduce the behavior:

  1. Create new project with react native
  2. Install react-native-activity-feed@1.1.1 and import in the code

Expected behavior As per recommendation in https://github.com/facebook/react-native/issues/33557#issuecomment-1212212561 if the import is updated to use deprecated-react-native-prop-types it should work

TianrenWang commented 2 years ago

LOL was expecting to find this question at the top of the issue. If they fix this, great, but I don't expect them to do that any time soon, maybe ever.

danjayrose commented 2 years ago

Yes I also thought the same as it seems that this isn't maintained anymore. To resolve the issue for my project I use patch-package to resolve the problem that seems to originate from react-native-keyboard-spacer.

TianrenWang commented 2 years ago

Yes I also thought the same as it seems that this isn't maintained anymore. To resolve the issue for my project I use patch-package to resolve the problem that seems to originate from react-native-keyboard-spacer.

@danjayrose By any chance, can I get a copy of that patch-package?

danjayrose commented 2 years ago

Sorry for the late reply, I've been on holiday. I've attached the patch file, just rename the file extension from .txt to .patch and put it in your patches folder

react-native-keyboard-spacer+0.4.1.txt