Inject Context into PushDelegate - Githubissues

GetStream / stream-android-push

Other

4 stars 1 forks source link

Inject Context into PushDelegate #3

Closed JcMinarro closed 1 year ago

JcMinarro commented 1 year ago

🎯 Goal

Inject Context into PushDelegate to be able to use Android Stuff from the custom implementation of PushDelegate. PushDelegate needed to be converted into an abstract class instead of an interface.

☑️Contributor Checklist

General

[x] I have signed the Stream CLA (required)
[x] Assigned a person / code owner group (required)
[x] Thread with the PR link started in a respective Slack channel (required)
[x] PR targets the develop branch
[x] PR is linked to the GitHub issue it resolves

Code & documentation

[ ] Changelog is updated with client-facing changes
[ ] New code is covered by unit tests
[ ] Comparison screenshots added for visual changes
[ ] Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

[ ] UI Components sample runs & works
[ ] Compose sample runs & works
[ ] UI Changes correct (before & after images)
[ ] Bugs validated (bugfixes)
[ ] New feature tested and works
[ ] Release notes and docs clearly describe changes
[ ] All code we touched has new or updated KDocs

🎉 GIF