GetStream / stream-chat-flutter

Flutter Chat SDK - Build your own chat app experience using Dart, Flutter and the Stream Chat Messaging API.
https://getstream.io/chat/sdk/flutter/
Other
918 stars 337 forks source link

Long-press reaction triggers web context menu on mobile #1908

Closed geweald closed 3 months ago

geweald commented 5 months ago

Which packages are you using?

stream_chat_flutter

On what platforms did you experience the issue?

iOS, Android

What version are you using?

Latest

What happened?

When long-pressing reaction on mobile, the web context menu appears. This should trigger the mobile menu or maybe better not trigger anything at all.

Plus to context menu is sometimes scrollable even if there is enough space on the screen (unless it must have top corner in the place of tap). And the context uses root navigator, which is not ideal if we want to embeed the chat deeper in the app (then we still need to provide stream configuration at the very top of the whole app)

Steps to reproduce

1. Open chat
2. Add reaction to a message
3. Long press the reaction

Supporting info to reproduce

No response

Relevant log output

No response

Flutter analyze output

No response

Flutter doctor output

No response

Code of Conduct

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 20 days with no activity.

github-actions[bot] commented 4 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale.

esarbanis commented 3 months ago

Hi @geweald,

The context menu is managed by the third party library contextmenu you are right that this library does use the root navigator and does not provide any size control as well.

As this is part of a larger refactor on our reaction menus, currently on our backlog, I am going to close this, but will address it with the new menus.

geweald commented 3 months ago

Hi @esarbanis

Thanks for the reply. To quick fix you can only use this / trigger the menu when kIsWeb (or desktop, but I haven't checked desktop, but issue is on iOS and Android)