GetStream / stream-chat-flutter

Flutter Chat SDK - Build your own chat app experience using Dart, Flutter and the Stream Chat Messaging API.
https://getstream.io/chat/sdk/flutter/
Other
880 stars 313 forks source link

refactor(ui): Update stream_chat_flutter.dart to make accessible message_widget_content_components.dart #1943

Closed guplem closed 2 weeks ago

guplem commented 2 weeks ago

Submit a pull request

CLA

Description of the pull request

Fixes #1941 by exporting the file in the main stream_chat_flutter file.

deven98 commented 2 weeks ago

@guplem can you remove the redundant imports in the files? You will see them in the lint errors.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.23%. Comparing base (b8d3822) to head (46eb8c1).

:exclamation: Current head 46eb8c1 differs from pull request most recent head bea2689

Please upload reports for the commit bea2689 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1943 +/- ## ======================================= Coverage 60.23% 60.23% ======================================= Files 317 317 Lines 18493 18493 ======================================= Hits 11140 11140 Misses 7353 7353 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

guplem commented 2 weeks ago

@guplem can you remove the redundant imports in the files? You will see them in the lint errors.

Done!

deven98 commented 2 weeks ago

Hey @guplem, there are more redundant imports in the files that need to be removed - you can also check the analysis on this PR for them. Additionally, you will also need to add a single line to the changelog (stream_chat_flutter/pubspec.yaml) in the upcoming section to explain the change.

I understand this may be repetitive for you so let me know if you do not have time for the changes and I can do them as well.

Thanks!

guplem commented 2 weeks ago

Hi @deven98

My mistake! I believe I've covered your requests. Thanks for your patience