GetStream / stream-chat-flutter

Flutter Chat SDK - Build your own chat app experience using Dart, Flutter and the Stream Chat Messaging API.
https://getstream.io/chat/sdk/flutter/
Other
880 stars 313 forks source link

fix(ui): Added `showReactionPickerTail` parameter for `MessageWidgetContent` #1946

Closed guplem closed 2 weeks ago

guplem commented 2 weeks ago

Submit a pull request

CLA

Description of the pull request

Allows to fix the visual issues described in #1879, but it does not solve the core issue

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (ff924da) to head (d0f4485).

:exclamation: Current head d0f4485 differs from pull request most recent head 942b2cd

Please upload reports for the commit 942b2cd to get more accurate results.

Files Patch % Lines
...flutter/lib/src/message_widget/message_widget.dart 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1946 +/- ## ========================================== - Coverage 60.23% 60.23% -0.01% ========================================== Files 317 317 Lines 18493 18494 +1 ========================================== Hits 11140 11140 - Misses 7353 7354 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deven98 commented 2 weeks ago

Thanks for creating this!

The PR itself looks great but I'm assuming we are effectively reverting #1762. I will take a look tomorrow to test out all cases after which I can likely merge this and solve any other cases myself in proceeding PRs.

guplem commented 2 weeks ago

I believe it is not exactly the same... we are providing now for an option to disable the "tail" without having to disable the "reaction picker".

deven98 commented 2 weeks ago

@guplem I've opened another PR which solves the picker tail showing up and also adds a parameter to set if you need to: https://github.com/GetStream/stream-chat-flutter/pull/1953

Regardless, thanks for the PR and your contributions :)