search

GetStream / stream-chat-php

Stream Chat official PHP API Client
https://getstream.io/chat/
BSD 3-Clause "New" or "Revised" License
30 stars 9 forks source link

Add exportChannel, exportChannels and getTask methods #60

Closed AnatolyRugalev closed 3 years ago

AnatolyRugalev commented 3 years ago

This PR adds exportChannel related functionality into SDK

gumuz commented 3 years ago

@AnatolyRugalev I know this is an older PR, but GetTask is not a good way to get the result of ExportChannel, see https://github.com/GetStream/stream-chat-js/blob/master/src/client.ts#L3082

the problem lies with the fact that the GetExportChannelStatus endpoint adds a signed S3 link, which is not done in the GetTask endpoint.

ferhatelmas commented 3 years ago

or we can do the refactoring to merge them (we will do eventually)

AnatolyRugalev commented 3 years ago

or we can do the refactoring to merge them (we will do eventually)

Yeah, this is probably a better in a long term