GetStream / stream-chat-react-native

๐Ÿ’ฌ React-Native Chat SDK โžœ Stream Chat. Includes a tutorial on building your own chat app experience using React-Native, React-Navigation and Stream
https://getstream.io/chat/sdk/react-native/
Other
977 stars 326 forks source link

fix: upgrade firebase versions to fix crash #2646

Closed isekovanic closed 2 months ago

isekovanic commented 2 months ago

๐ŸŽฏ Goal

This PR should actually fix what I thought this one would.

Considering that most of the changes around the library happen in the Firebase native libraries, it's a bit difficult to say (for sure) what the offending code was since the failure in the native layer happened during some remote settings registration, but it's very likely that it's these two:

๐Ÿ›  Implementation details

Aside from the version upgrade, I also added a release only profile to our iOS ones. It might come in handy for someone else too, since this issue only happened in Release builds and Debug ones were unaffected.

๐ŸŽจ UI Changes

iOS
Before After
Android
Before After

๐Ÿงช Testing

โ˜‘๏ธ Checklist

stream-ci-bot commented 2 months ago

:tada: This PR is included in version 5.36.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: