fix: changing orientation attachment picker issues

isekovanic commented 6 days ago

🎯 Goal

Solves this GH issue. Details of the reproduction steps can be found in the issue itself.

Here is a brief summary of why this issue is happening:

Looking at the containerHeight property in the library as well as looking at the implementation for a bit, we can clearly see that:
- This value is not meant to be used as a dynamic one
- It completely prevents recalculation from the library itself and relies on this value solely
Typically, whenever we change landscape the value for the top area insets changes (as well as the screen height) and this is passed as a dynamic value to the containerHeight; the BottomSheet is however not shown as it's being controlled entirely by our OverlayProvider
Whenever we come back from background mode of the app however, we have a refresh in values that happens "late", and the initial value passed to containerHeight is wrong; only to be updated soon after
This however causes the wrong value to be used within the library itself (instead of calculations) and the new value is not respected at all (nor should it, considering that it skips extra rerenders due to calculations) and we end up in a weird state where the BottomSheet is displayed without any of its actual functionalities

The issue is reproducible on virtually any screen by the way, since the OverlayProvider is basically the root of our DOM tree.

iOS

Before	After

Android

Before	After

[ ] I have signed the Stream CLA (required)
[ ] PR targets the develop branch
[ ] Documentation is updated
[ ] New code is tested in main example apps, including all possible scenarios
- [ ] SampleApp iOS and Android
- [ ] Expo iOS and Android

Stream-SDK-Bot commented 6 days ago

`title`	`develop`	`branch`	`diff`	`status`
js_bundle_size	442.099609375 KB	442 KB	0 B	🟢

stream-ci-bot commented 6 days ago

:tada: This PR is included in version 5.38.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: