search

GetStream / stream-chat-react

React Chat SDK ➜ Stream Chat 💬
https://getstream.io/chat/sdk/react/
Other
698 stars 272 forks source link

feat: configure message group size by max time between messages #2439

Closed MartinCupela closed 2 months ago

MartinCupela commented 2 months ago

🎯 Goal

The goal is the parity with RN Chat SDK.

🛠 Implementation details

If the value of maxTimeBetweenGroupedMessages is greater then the difference btw the current and next message creation date, the groupd is considered to end with the current message. Effectively, what happens is that the message is applied a class str-chat__li--bottom. The visual result is reflected in MessageList (each message has timestamp and author (metadata) shown) but not in VirtualizedMessageList which has additional logic that decides whether a group ends at a given message. This should be synced with the MessageList but potentially introducing breaking changes to the integrators using VirtualizedMessageList :it_is_what_it_is_emoji.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.44%. Comparing base (741e9ce) to head (bd824a5). Report is 1 commits behind head on release-v11.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-v11 #2439 +/- ## ============================================ Coverage 85.44% 85.44% ============================================ Files 392 392 Lines 9084 9084 Branches 2346 2346 ============================================ Hits 7762 7762 Misses 1121 1121 Partials 201 201 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stream-ci-bot commented 2 months ago

:tada: This PR is included in version 11.23.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: