GetStream / stream-chat-react

React Chat SDK ➜ Stream Chat 💬
https://getstream.io/chat/sdk/react/
Other
698 stars 272 forks source link

bug: React versions <18 fail to compile #2455

Closed kylemellander closed 1 month ago

kylemellander commented 1 month ago

When installing in a project that using React > 16.8 or React 17, compilation fails when attempting to resolve react/jsx-runtime. The reason for this failure is the pinned version of react-markdown requires React > 18.

To Reproduce

Steps to reproduce the behavior:

  1. I created a simple reproduction of the issue here.
  2. run yarn build to see the failure.

Expected behavior

I would expect the JavaScript to compile OR the requirement to be clear that you need to be on React > 18.

Screenshots

Screenshot 2024-07-24 at 9 23 02 AM

Package version

Additional context

I know that it is possible to work around this with configuration of the build process, but this problem ends up bubbling up through all our projects that utilize the library (even indirectly), and it feels janky to have that need for configuration to leak out.

MartinCupela commented 1 month ago

Hey @kylemellander we are looking into the option how to alleviate the inconvenience.

stream-ci-bot commented 1 month ago

:tada: This issue has been resolved in version 11.23.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stream-ci-bot commented 4 weeks ago

:tada: This issue has been resolved in version 12.0.0-rc.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: