search

GetStream / stream-chat-react

React Chat SDK ➜ Stream Chat 💬
https://getstream.io/chat/sdk/react/
Other
698 stars 272 forks source link

fix: prevent including own user in read count displayed in MessageStatus #2459

Closed MartinCupela closed 1 month ago

MartinCupela commented 1 month ago

🎯 Goal

Correctly account for the presence of own user in the message readers' array and don't just assume it is always present.

🛠 Implementation details

Once we know a message has been read by someone else, let's take an array of other users who read the message and base the reader count rendering on that.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.49%. Comparing base (28e26ca) to head (0df06df). Report is 15 commits behind head on release-v11.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-v11 #2459 +/- ## ============================================= Coverage 85.48% 85.49% ============================================= Files 393 393 Lines 9122 9127 +5 Branches 2356 2492 +136 ============================================= + Hits 7798 7803 +5 + Misses 1122 926 -196 - Partials 202 398 +196 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stream-ci-bot commented 1 month ago

:tada: This PR is included in version 11.23.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stream-ci-bot commented 4 weeks ago

:tada: This PR is included in version 12.0.0-rc.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: