GetStream / stream-chat-swift

💬 iOS Chat SDK in Swift - Build your own app chat experience for iOS using the official Stream Chat API
https://getstream.io/chat/sdk/ios/
Other
861 stars 211 forks source link

[Swift6] Fix converting value causes data races warnings in Xcode 16 #3456

Closed laevandus closed 1 month ago

laevandus commented 1 month ago

🎯 Goal

Fix warnings:

ChatClient.swift:584:54: Converting a value of type '(__shared sending Result<AppSettings, any Error>) -> ()' to type '(Result<AppSettings, any Error>) -> Void' risks causing data races; this is an error in the Swift 6 language mode

☑️ Contributor Checklist

github-actions[bot] commented 1 month ago
1 Message
:book: There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by :no_entry_sign: Danger

Stream-SDK-Bot commented 1 month ago

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢
Stream-SDK-Bot commented 1 month ago

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 8.34 ms 16.6% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 3.27 ms per s 18.25% 🔼 🟢
Frame rate 75 fps 78.49 fps 4.65% 🔼 🟢
Number of hitches 1 0.4 60.0% 🔼 🟢
Stream-SDK-Bot commented 1 month ago

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
164 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud