GetStream / stream-chat-swift

๐Ÿ’ฌ iOS Chat SDK in Swift - Build your own app chat experience for iOS using the official Stream Chat API
https://getstream.io/chat/sdk/ios/
Other
861 stars 210 forks source link

Fix channel list state views not updating when the view is not visible #3479

Closed nuno-vieira closed 3 weeks ago

nuno-vieira commented 3 weeks ago

๐Ÿ”— Issue Links

None. Found the issue when investigating https://stream-io.atlassian.net/browse/PBE-6291 for SwiftUI.

๐ŸŽฏ Goal

Fixes a rare case where the channel list won't update the state views if the view is not on the screen. (Example, creating a channel)

๐Ÿ›  Implementation

The issue was that when skipping the channel list rendering while the view is off-screen, we were not calling the update on the channel list state views, which caused the empty view to not disappear.

๐Ÿงช Manual Testing Notes

1- Open the Demo App 2- Login with Guest User 3- Create a DM Channel 4- Go back to the Channel List 5- The channel list should have the new channel and not the empty view.

โ˜‘๏ธ Contributor Checklist

Stream-SDK-Bot commented 3 weeks ago

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB ๐ŸŸข
StreamChatUI 4.95 MB 4.95 MB 0 KB ๐ŸŸข
Stream-SDK-Bot commented 3 weeks ago

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 0.0 ms 100.0% ๐Ÿ”ผ ๐ŸŸข
Duration 2.6 s 2.55 s 1.92% ๐Ÿ”ผ ๐ŸŸข
Hitch time ratio 4 ms per s 0.0 ms per s 100.0% ๐Ÿ”ผ ๐ŸŸข
Frame rate 75 fps 78.57 fps 4.76% ๐Ÿ”ผ ๐ŸŸข
Number of hitches 1 0.0 100.0% ๐Ÿ”ผ ๐ŸŸข
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
164 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud