Closed nuno-vieira closed 3 weeks ago
title |
develop |
branch |
diff |
status |
---|---|---|---|---|
StreamChat | 6.92 MB | 6.92 MB | 0 KB | ๐ข |
StreamChatUI | 4.95 MB | 4.95 MB | 0 KB | ๐ข |
target |
metric |
benchmark |
branch |
performance |
status |
---|---|---|---|---|---|
MessageList | Hitches total duration | 10 ms | 0.0 ms | 100.0% ๐ผ | ๐ข |
Duration | 2.6 s | 2.55 s | 1.92% ๐ผ | ๐ข | |
Hitch time ratio | 4 ms per s | 0.0 ms per s | 100.0% ๐ผ | ๐ข | |
Frame rate | 75 fps | 78.57 fps | 4.76% ๐ผ | ๐ข | |
Number of hitches | 1 | 0.0 | 100.0% ๐ผ | ๐ข |
Issues
164 New issues
0 Accepted issues
Measures
0 Security Hotspots
84.4% Coverage on New Code
0.1% Duplication on New Code
๐ Issue Links
None. Found the issue when investigating https://stream-io.atlassian.net/browse/PBE-6291 for SwiftUI.
๐ฏ Goal
Fixes a rare case where the channel list won't update the state views if the view is not on the screen. (Example, creating a channel)
๐ Implementation
The issue was that when skipping the channel list rendering while the view is off-screen, we were not calling the update on the channel list state views, which caused the empty view to not disappear.
๐งช Manual Testing Notes
1- Open the Demo App 2- Login with Guest User 3- Create a DM Channel 4- Go back to the Channel List 5- The channel list should have the new channel and not the empty view.
โ๏ธ Contributor Checklist