Replace shared current user observer used for reading privacy settings

laevandus commented 2 days ago

🔗 Issue Links

Part of IOS-558

🎯 Goal

Remove current user controller since it takes unnecessary CPU time when reacting to DB changes

📝 Summary

Replace internal current user controller with just reading the data directly

🛠 Implementation

We had a perf issue some time ago where we used to create the ChatCurrentUserController every single time when checking for typing state (on each key press). Then we started to use a shared instance for that. Solved the issue, but there is one downside, reacting to current user changes can get expensive (e.g. current user has many muted channels which triggers recreating channel objects when updating the immutable CurrentChatUser type). Instead all of this, we should just read the data we need and skip controllers.

🧪 Manual Testing Notes

Try typing events, if disabled, should not appear, otherwise appear.

☑️ Contributor Checklist

[x] I have signed the Stream CLA (required)
[x] This change should be manually QAed
[x] Changelog is updated with client-facing changes
[ ] Changelog is updated with new localization keys
[x] New code is covered by unit tests
[ ] Comparison screenshots added for visual changes
[ ] Affected documentation updated (docusaurus, tutorial, CMS)

Stream-SDK-Bot commented 2 days ago

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamChat	7.02 MB	7.02 MB	0 KB	🟢
StreamChatUI	4.96 MB	4.96 MB	0 KB	🟢

Stream-SDK-Bot commented 2 days ago

SDK Performance

`target`	`metric`	`benchmark`	`branch`	`performance`	`status`
MessageList	Hitches total duration	10 ms	3.34 ms	66.6% 🔼	🟢
	Duration	2.6 s	2.55 s	1.92% 🔼	🟢
	Hitch time ratio	4 ms per s	1.31 ms per s	67.25% 🔼	🟢
	Frame rate	75 fps	78.22 fps	4.29% 🔼	🟢
	Number of hitches	1	0.4	60.0% 🔼	🟢