Closed laevandus closed 1 month ago
title |
develop |
branch |
diff |
status |
---|---|---|---|---|
StreamChatSwiftUI | 7.06 MB | 7.06 MB | +2 KB | ๐ข |
Issues
88 New issues
0 Accepted issues
Measures
0 Security Hotspots
72.2% Coverage on New Code
0.0% Duplication on New Code
๐ Issue Link
Resolves: PBE-5810
๐ฏ Goal
Fix the issue or marking a channel as read when the first unread message was one of the first not visible messages
๐ Implementation
The fix is a workaround to the SwiftUI issue where the LazyVStack pushed to the NavigationStack has initially larger height and therefore trigger onAppear for more messages than it should. This causes
ChatChannelViewModel
to mark the channel as read because it thinks the user also saw the first unread message. Apple's feedback id is: FB15010770.๐งช Testing
Before: Unread message pill appeared for a split second and the channel was marked as read Expected: Unread message pill appears at the top of the channel view.
๐จ Changes
Note how in the before video the second opening on the channel marked it as read (the pill went away).
โ๏ธ Checklist