Closed yaziine closed 2 years ago
LGTM
probably a good moment to add some linting, CI/CD to the project in the next iteration
please create issues for this kind of items and move on
please create issues for this kind of items and move on
yep already done https://github.com/GetStream/chat/issues/3335
How is deleting a default app config supposed to be working? Since we clear default, are we making config invalid at this stage or are we going to take first if default is missing since apps is a list, that makes sense to me.
How is deleting a default app config supposed to be working? Since we clear default, are we making config invalid at this stage or are we going to take first if default is missing since apps is a list, that makes sense to me.
Thanks for asking. Here is how I see it:
--app
is provided it should work, eg:
stream-cli channels create XYZ --app prod
--app
is not provided it should fail with an error, eg:
no default application configured, please use --app or define a default app using `stream-cli config default` command
Here is how I see it
Sounds good, explicit
merging this so that @peterdeme can continue
This PR adds commands to manage configuration:
An app configuration is represented by:
The first new added configuration will be considered as the default one, this can be change with the
default
command.