feat: add channel crud - Githubissues

GetStream / stream-cli

Configure & manage Stream applications from the command line. 🚀

https://yarnpkg.com/en/package/getstream-cli

BSD 3-Clause "New" or "Revised" License

85 stars 19 forks source link

feat: add channel crud #76

Closed peterdeme closed 2 years ago

peterdeme commented 2 years ago

Added Channel CRUD commands in this PR (create, get, update, delete, list)
Prepared the self-update command for the next iteration. Will be finalized in later stages.

peterdeme commented 2 years ago

ferhatelmas commented 2 years ago

Let's try to follow these suggestions:

add one liners to description so that reviewers can know what to expect in PR
extract unnecessary things (such as CI) and split the PR
don't overwrite the actual readme just yet since we don't release, not to create confusion (if solely can work on a branch, fine though)

peterdeme commented 2 years ago

@ferhatelmas you're right, I just went ahead and added a bunch of draft things. Shouldn't have done.

I added a description. Removed readme and CI.

ferhatelmas commented 2 years ago

I added a description. Removed readme and CI.

thanks, feel free to merge CI first so that it can catch issues earlier

yaziine commented 2 years ago

@peterdeme didn't we say we move to cobra first?

peterdeme commented 2 years ago

@yaziine we said after the PR is merged

yaziine commented 2 years ago

I thought we said the opposite. Since those changes will be refactored, there is no need to push them now imho, I suggest to:

freeze this PR for now
move to cobra
refactor this PR and merge

cc @ferhatelmas @gumuz

gumuz commented 2 years ago

FWIW, I also understood it was after this PR was merged, since it was still small and wouldn't need a lot of work. Does it really matter though which order it happens in, since Peter is the one doing it?

yaziine commented 2 years ago

Closing this in favor of https://github.com/GetStream/stream-cli/pull/77