GetStream / stream-feed-flutter

Stream Feed official Flutter SDK. Build your own feed experience using Dart and Flutter.
https://getstream.io
Other
71 stars 70 forks source link

Incorrect Types for height an width in OpenGraphData Model #247

Open harsh-verma-jtg opened 1 year ago

harsh-verma-jtg commented 1 year ago

Describe the bug I'm currently trying to fetch open graph data from an URL as mentioned in stream_feed's documentation we can use client.og(previewUrl) method to fetch open graph data https://getstream.io/activity-feeds/docs/flutter-dart/open_graph_scraping/?language=dart&q=client.og If I look inside the OpenGraphData model the height and width property of OgImage and OgVideo model are marked as String? type but in the API response both values are of integer type due to which whenever there is a height and width value received in API response error is thrown while parsing those due to type mismatch. Here is the log of the error _message: "Expected a value of type 'String?', but got one of type 'int'"

Screenshot from 2023-03-15 15-11-53 Screenshot from 2023-03-15 13-28-15

What version of Flutter do you use? 3.7.0

What package are you using? What version? stream_feed_flutter_core

What platform is it about?

To Reproduce Try to fetch metadata of URLs which have height and width property in response one example for it is https://google.com

Expected behavior

There should be consistency between API response and models created on frontend, most probably height and width should be of type int? so changes most probably be needed on frontend side to fix the issue

Screenshot from 2023-03-15 20-16-45

harsh-verma-jtg commented 1 year ago

Possible Fix would be correcting type of width and height in OpenGraphModel using int? width, and int? height instead of String? height, String? width.

Screenshot from 2023-03-16 13-29-41

followthemoney1 commented 1 year ago

@hdiogenes @jeroenleenarts @gumuz @tbarbugli are there any updates planning on the plugin? There was 11 month or inactivity

tayormi commented 10 months ago

i don’t think there’s any plan for updates to this package, even though we depend on it. I probably will create a fork out of this for what I need.