GetStream / stream-feed-flutter

Stream Feed official Flutter SDK. Build your own feed experience using Dart and Flutter.
https://getstream.io
Other
71 stars 71 forks source link

Stream Feeds and Chat incompatible due to reliance on DIO package. #251

Open SKLn-Rad opened 1 year ago

SKLn-Rad commented 1 year ago

Describe the bug As it stands, we're unable to continue development as you have patched the version of DIO in your chat solution and you haven't aligned the feeds package in over around 11 months. Even if I fork it, this then leads to 400s being thrown from the SDK.

What version of Flutter do you use? 3.10.0 and 3.7.0

What package are you using? What version? 6.1.0 -> Stream Chat 6.1.0 -> Stream Persistence 0.6.0+2 -> Stream Feeds 0.8.0 -> Feeds Core

What platform is it about?

a copy of flutter doctor --verbose

To Reproduce Steps to reproduce the behavior:

  1. Try to add both packages to your project
  2. ...
  3. Profit?

Expected behavior Packages work as intended, and when errors occur; the error is properly propagated and handled, not absorbed into a json decoding issue and hidden.

Screenshots image

https://github.com/GetStream/stream-feed-flutter/blob/master/packages/stream_feed/pubspec.yaml https://github.com/GetStream/stream-chat-flutter/blob/develop/packages/stream_chat/pubspec.yaml

Logs Redacted the output of Flutter Analyse, please don't ask your users to post information which could essentially banner grab them. This is not a clever idea.

[!] Flutter (Channel stable, 3.10.0, on Microsoft Windows [Version 10.0.23451.1000], locale en-GB) • Flutter version 3.10.0 on channel stable at C:\Users_\fvm\versions\3.10.0 ! Warning: dart on your path resolves to C:\tools\dart-sdk\bin\dart.exe, which is not inside your current Flutter SDK checkout at C:\Users_\fvm\versions\3.10.0. Consider adding C:\Users_\fvm\versions\3.10.0\bin to the front of your path. • Upstream repository https://github.com/flutter/flutter.git • Framework revision 84a1e904f4 (5 days ago), 2023-05-09 07:41:44 -0700 • Engine revision d44b5a94c9 • Dart version 3.0.0 • DevTools version 2.23.1 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2) • Android SDK at C:\Users_\AppData\Local\Android\Sdk • Platform android-33, build-tools 33.0.2 • ANDROIDHOME = C:\Users\\AppData\Local\Android\Sdk • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694) ✗ Android license status unknown. Run flutter doctor --android-licenses to accept the SDK licenses. See https://flutter.dev/docs/get-started/install/windows#android-setup for more details. ^-- New install, this isn't the issue.

[✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe) ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✗] Visual Studio - develop for Windows ✗ Visual Studio not installed; this is necessary for Windows development. Download at https://visualstudio.microsoft.com/downloads/. Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2022.2) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[✓] VS Code (version 1.78.2) • VS Code at C:\Users_\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.65.20230510

[✓] Connected device (3 available) • SM G973F (mobile) • _ • android-arm64 • Android 10 (API 29) • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.23451.1000] • Edge (web) • edge • web-javascript • Microsoft Edge 113.0.1774.42

[✓] Network resources • All expected network resources are available.

! Doctor found issues in 4 categories.

followthemoney1 commented 1 year ago

@SKLn-Rad workaround, should fix your problem:

image

You could use this fork: https://github.com/followthemoney1/stream-feed-flutter

  stream_feed_flutter_core:
    #path: /Users/dmitrydyachenko/Desktop/stream-feed-flutter/packages/stream_feed_flutter_core
    git:
      url: https://github.com/followthemoney1/stream-feed-flutter.git
      ref: master
      path: packages/stream_feed_flutter_core

pull request: https://github.com/GetStream/stream-feed-flutter/pull/253

rlee1990 commented 1 year ago

@followthemoney1 do you plan on updating this to the latest version of Dio?

followthemoney1 commented 1 year ago

@followthemoney1 do you plan on updating this to the latest version of Dio?

Do you need to update this? I will