GetStream / stream-java

Java Client - Build Activity Feeds & Streams with GetStream.io
https://getstream.io
BSD 3-Clause "New" or "Revised" License
56 stars 48 forks source link

Wrong api call from getEnrichedCustomActivities #106

Open fso-msrl opened 2 years ago

fso-msrl commented 2 years ago

I want to use my custom enriched activity, and I tried to call getEnrichedCustomActivities, but it returns a list of activity data models.

I think it is because now this function is call getActivities api ([domain]/api/v1.0/feed/xxxx), it should call getEnrichedActivities api ([domain]/api/v1.0/enrich/feed/xxxx), right?

peterdeme commented 2 years ago

@fso-seekers using any of these methods should call the enrich endpoint

fso-msrl commented 2 years ago

@peterdeme hm...but I want to use Custom and Enriched Activities. If I use getEnrichedActivities, I need to create the convertor by myself. For Example:

  1. call getEnrichedActivities
  2. convert to MyCustomEnrichedActivity List

So I want to use these, seems that if these works I no need to convert two times (json -> enrichedActivities -> MyCustomEnrichedActivity list)

In CloudFlatFeed.java, by your function name, should get Enriched and Custom activity list. If I missed understanding, would you mind telling me what cases I can use these functions?

CompletableFuture> getEnrichedCustomActivities( Class type, Limit limit, Offset offset, Filter filter, EnrichmentFlags flags, String ranking) throws StreamException { final RequestOption[] options = ranking == null ? new RequestOption[] {limit, offset, filter, flags, DefaultOptions.DEFAULT_MARKER} : new RequestOption[] { limit, offset, filter, flags, DefaultOptions.DEFAULT_MARKER, new Ranking(ranking) }; return getClient() `.getActivities(getID(), options)` <-- works if call getEnrichedActivities? .thenApply( (Response response) -> { try { return deserializeContainer(response, type); } catch (StreamException | IOException e) { throw new CompletionException(e); } }); }