search

GetStream / stream-js

JS / Browser Client - Build Activity Feeds & Streams with GetStream.io
https://getstream.io
BSD 3-Clause "New" or "Revised" License
331 stars 110 forks source link

Protect against running multiple Stream/Faye clients #129

Open tschellenbach opened 6 years ago

tschellenbach commented 6 years ago

Running multiple Faye clients leads to this bug:

https://github.com/GetStream/stream-js/issues/72

Which is very obscure and hard to debug. Wonder if we could provide a better error.

thesyncim commented 6 years ago

i believe this is related to #198: take a look at after reading more carefully the code it looks like that the reference client doesn't care about about the the subscription.

tbarbugli commented 6 years ago

@tschellenbach correct me if I wrong but AFAIK we observed this issue back when we were still using the JS implementation of Faye server-side and concluded that the problem was client-side

tschellenbach commented 6 years ago

Yeah this is broken with the standard Faye server. ID generation is global, so if you start 2 clients you get clashes.