search

GetStream / stream-js

JS / Browser Client - Build Activity Feeds & Streams with GetStream.io
https://getstream.io
BSD 3-Clause "New" or "Revised" License
331 stars 110 forks source link

Subscription won't receive faye update when feed.get({ mark_seen: true}) #275

Open dgarciamuria opened 4 years ago

dgarciamuria commented 4 years ago

I came across this bug in a react native app (https://github.com/GetStream/react-native-activity-feed/issues/93). Originally reported in their repo but I think it belongs here. Essentially, if a subscription is created to a user's notifications feed notifications.subscribe(data => doSomething) it wont get called if later retrieving that feed with mark_seen: true option. This affects their IconBadge component, where the counter gets out of sync after marking all notifications as read.

shodgetts commented 4 years ago

Hey! Thanks for getting in touch, we'll take a look at this and try to recreate the issue. Bear with us!

wodow commented 3 years ago

@shodgetts Were you able to do recreate?

I am experiencing the same surface bug as per https://github.com/GetStream/react-native-activity-feed/issues/93#issuecomment-809273185

wodow commented 3 years ago

Could this be related to https://github.com/GetStream/stream-js/issues/423 ?

amakhrov commented 2 years ago

Any updates here? I can confirm that realtime messages are not coming for mark_read or mark_seen updates. It makes it impossible to keep an up-to-date notifications counter, without periodically polling the feed (which defeats the purpose of realtime)