GetStream / stream-js

JS / Browser Client - Build Activity Feeds & Streams with GetStream.io
https://getstream.io
BSD 3-Clause "New" or "Revised" License
330 stars 110 forks source link

Package JSON is being bundled in the JavaScript dist code #549

Closed Buzzertech closed 1 year ago

Buzzertech commented 1 year ago

Context

We have noticed that this library ships about 3kb of it's package.json content with it's dist code

Current behaviour

The culprit seems to be this import inside client.ts where the pkg is being imported to retrieve the library version which is used here.

Expected behaviour

You could inject the version string at build time by using webpack's DefinePlugin.

xernobyl commented 1 year ago

Thank you for the input. We're deploying a fix.