GetStream / stream-python

Python Client - Build Activity Feeds & Streams with GetStream.io
https://getstream.io
BSD 3-Clause "New" or "Revised" License
142 stars 40 forks source link

Feature/clean urls #67

Closed tbarbugli closed 6 years ago

tbarbugli commented 6 years ago

Summary:

Change how urls are constructed for API, Collections and Personalization.

Regular API endpoints:

https://${api_location}-api.stream-io-api.com/api/v1.0/
https://api.stream-io-api.com/api/v1.0/

Personalization API endpoints:

https://${api_location}-personalization.stream-io-api.com/personalization/v1.0/
https://personalization.stream-io-api.com/personalization/v1.0/

Collections API endpoint:

https://${api_location}-api.stream-io-api.com/api/v1.0/meta/
https://api.stream-io-api.com/api/v1.0/meta/

This PR should also keep supporting QA test runs, local test runs (LOCAL=1), Heroku URLs and the use of arbitrary urls provided via base_url.

Submitter checklist:

Merger checklist:

Dependencies:

tschellenbach commented 6 years ago

With this approach we also need to verify that the domains are used correctly:

tbarbugli commented 6 years ago

@tschellenbach both uacf-personalization.stream-io-api.com and personalization.stream-io-api.com point to the ELB if that does not work let me and Alessandro know.

BalazsHoranyi commented 6 years ago

Did not mean to push that last change, apologies. Next push should put it back to where it was before.