Closed ferhatelmas closed 4 years ago
so what is the result? No need to bother?
Yup
On Thu, Nov 7, 2019, 9:52 AM ferhat elmas notifications@github.com wrote:
so what is the result? No need to bother?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/GetStream/stream-python/issues/95?email_source=notifications&email_token=AAAVVH52ADQFQOJUQRFXELLQSRBUZA5CNFSM4IUVJRVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNCFLQ#issuecomment-551166638, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVVH7P55EFIAZ5TWUTQPLQSRBUZANCNFSM4IUVJRVA .
Problem explanation
Nothing specifically wrong but could be improved, IMHO.
Generally, previous idiom is followed but
response
could be returned directly without losing any significant information but it might improve readability by making implementation shorter since it's repeated many times.Suggestion is as following:
Steps to reproduce
None, above description is self contained.
Environment info
N/A
Error traceback (if applicable)
N/A
Code snippet that causes the problem
N/A