GetStream / stream-ruby

Ruby Client - Build Activity Feeds & Streams with GetStream.io
https://getstream.io
BSD 3-Clause "New" or "Revised" License
85 stars 32 forks source link

[WIP] Replacing HTTParty to Faraday #62

Closed rsbarbo closed 7 years ago

rsbarbo commented 7 years ago

@iandouglas - Hi Ian, I have fixed most of the test (58 examples, 35 failures), however the only issue we have right now is getting the params passing into connection (Faraday) fixed up and everything else should pass. I think the only other issue we will have to fix before we can go ahead and merge this PR is to fix the raise ERROR issue since the way Faraday is now setup works slightly different from HTTParty. So if you fix the params to return 200 rather than 404's, please let me know and I will go ahead and finish up all the rest that needs to be fixed. Also If want me to go ahead and explore some more the params that needs to be passed, I will gladly look over the documentation and get fixed up. Thanks for the opportunity - Raphael Barbo