Closed mohamadrezakoohkan closed 1 year ago
Hi @mohamadrezakoohkan,
It is unfortunate that Starscream has added a breaking change in a patch release 😞 , but we are going to proceed with merging this PR so it not an issue anymore.
Thank you for you contribution!
Submit a pull request
This pull request addresses an issue, where it has become non-functional due to recent changes in the Starscream library. Specifically, the Starscream library's 4.0.x (4.0.5 & 4.0.6) version update introduced a new enum case called
case peerClosed
inWebSocketEvent
enum class (details here) and has broken the conformance of the Client object to theWebSocketDelegate
protocol, leaving the project uncompilable.Build Error Encountered:
A screenshot of the encountered error is shown below:
The issue originates from the fact that GetStream has been set up to track the latest changes to the major version of Starscream through its Package.swift file: Package.swift
The proposed solution in this pull request involves incorporating the new
WebSocketEvent.peerClosed
enum case and updating the delegate method inputs to receive an abstraction of WebSocket, consistent with the WebSocketClient definition.The resolved state without errors is depicted in the screenshot below:
CLA