search

GetStream / stream-video-js

GetStream JavaScript Video SDK
https://getstream.io/video/sdk/
Other
66 stars 22 forks source link

feat(composite): support for participant.aspect-ratio #1381

Closed oliverlaz closed 3 months ago

oliverlaz commented 4 months ago

Overview

Adds participant.aspect-ratio configuration property that controls the aspect ratio of the ParticipantView. It accepts any valid CSS aspect ratio (16/9, 9/16, 1/1...).

Context: https://getstream.slack.com/archives/C022N8JNQGZ/p1716897250015959

szuperaz commented 3 months ago

The e2e tests are failing, we probably need to update the screenshots, however, this particular screenshot indicates that we might have a layout issue, because the bottom of the last participant row seem to be cropped.

Screenshot 2024-06-04 at 09 39 08

oliverlaz commented 3 months ago

The e2e tests are failing, we probably need to update the screenshots, however, this particular screenshot indicates that we might have a layout issue, because the bottom of the last participant row seem to be cropped.

Screenshot 2024-06-04 at 09 39 08

hey @szuperaz, I removed the default aspect ratio (that affected all layouts) and the tests are passing now: https://github.com/GetStream/stream-video-js/pull/1381/commits/6789fa381ab25082beb3c0f675eaaa8b74e3bc03

This could be problematic in production, but if someone plays with this property, they should be aware that some things might not look right.