[Improvement]Locking mechanisms and Atomic property wrapper - Githubissues

GetStream / stream-video-swift

SwiftUI Video SDK ➡️ Stream Video 📹

https://getstream.io/video/sdk/ios/

Other

118 stars 21 forks source link

[Improvement]Locking mechanisms and Atomic property wrapper #588

Closed ipavlidakis closed 3 weeks ago

ipavlidakis commented 4 weeks ago

🎯 Goal

Improve our locking mechanisms (used to ensure thread-safe access) and add tests to verify stability.

📝 Summary

This revision is attempting to align our locking mechanisms (under a single interface) while extending the Atomic property wrapper to be configured with the desired mechanism based on the requirements.

🛠 Implementation

A LockQueueing protocol that will be used as the identifying interface between our locking mechanisms.
The existing UnfairQueue conforms to the new LockQueueing protocol.
A new RecursiveQueue that uses a NSRecursiveLock underneath and conforms to LockQueueing.
An update on the Atomic property wrapper that can now be configured with the desired mechanism.
Added tests that ensure concurrentAccess and deadlock impossibility.

☑️ Contributor Checklist

[x] I have signed the Stream CLA (required)
[x] This change follows zero ⚠️ policy (required)
[x] This change should receive manual QA
[ ] Changelog is updated with client-facing changes
[x] New code is covered by unit tests
[ ] Comparison screenshots added for visual changes
[ ] Affected documentation updated (Docusaurus, tutorial, CMS)

Stream-SDK-Bot commented 4 weeks ago

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamVideo	7.46 MB	7.46 MB	0 KB	🟢
StreamVideoSwiftUI	2.18 MB	2.18 MB	0 KB	🟢
StreamVideoUIKit	2.31 MB	2.31 MB	0 KB	🟢
StreamWebRTC	8.69 MB	8.69 MB	0 KB	🟢

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
119 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud