lachie commented 6 years ago

The output of my OSX bindfs umount was slightly different to that expected by vg localInstall, so activation failed.

Not yet tested on fusermount.

codecov-io commented 6 years ago

Codecov Report

Merging #27 into master will decrease coverage by 0.45%. The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #27      +/-   ##
=======================================
- Coverage   52.45%   52%   -0.46%     
=======================================
  Files          28    27       -1     
  Lines         671   673       +2     
=======================================
- Hits          352   350       -2     
- Misses        220   224       +4     
  Partials       99    99

Impacted Files	Coverage Δ
internal/workspace/localInstall.go	`39.44% <0%> (-0.9%)`	:arrow_down:
main.go

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69cbc98...4b1e41d. Read the comment docs.

JelteF commented 6 years ago

Thanks for the PR. It looks fine to me, I always considered parsing the output of the command a bit fragile but couldn't think of a better way. Could you make some small unit tests that check the behaviour of these new functions you created?

JelteF commented 6 years ago

I just added the tests myself. Thanks for the PR and reporting the issue.

GetStream / vg

use functions to handle bindfs umount tool output more flexibly #27

Codecov Report