search

GetTogetherComm / GetTogether

Event manager for local community events
https://gettogether.community
BSD 2-Clause "Simplified" License
472 stars 89 forks source link

iCal lacks time zone information #294

Open Marwe opened 3 years ago

Marwe commented 3 years ago

The iCal export lacks time zone information, so my calendar (evolution) assumes UTC then and shifts the event to a wrong time.

Timezone is set for the team, but seems not to be used in the ical export. I saved a diff after setting the timezone in my calendar, see attachment. The time zone definition in the beginning seems complex (with daylight saving) and if I remember correctly, time zone definitions are not standardised, that may be the reason for the calendar software (evolution) to embed it so verbosely.

May be looked at together with #116 and #114

Attaching failed, diff can be found as paste for one year, otherwise it is easily reproducible with any ical import/export: https://paste.ubuntu.com/p/qgzjvWsf38/

Marwe commented 3 years ago

Another, more recent saved ics contains an explicit X-WR-TIMEZONE:UTC which is not the timezone of the team.

Thunderbird/Lightning has a less verbose TZ definition, diff at https://paste.ubuntu.com/p/YyNYNntySp/

Marwe commented 3 years ago

I guess the timezone definition is hardcoded here and this might be the issue:

https://github.com/GetTogetherComm/GetTogether/blob/c6f43a65a5fb3323a15c086655e32e4cd5b5bbb7/events/feeds.py#L82

Marwe commented 3 years ago

It seems to be configurable in the time zone selector in the 'place' information. Choosing the correct time zone of the event there yields correct ical export (time properly given in UTC).

There might be reasons to bind timezone to places (different schedule/start at different places, an event might be worldwide). Anyway, choosing the (main) timezone together with the event time would be good.

CaptainStack commented 2 years ago

+1 please add timezone support in both the web UX and iCal. I have been using GetTogether to host online meetings attended by folks from many timezones and I have to just add a note in the description.