GetValkyrie / valkyrie

Valkyrie is an opinionated local dev stack that makes features/git based Drupal development easy.
http://www.getvalkyrie.com
GNU General Public License v3.0
45 stars 11 forks source link

Breaks when a domain is added without a dot in the name #4

Open MatthewHager opened 9 years ago

MatthewHager commented 9 years ago

If we can't fix this we need to then not allow this to happen in the UI. Is it possible to make the aliases inside the VM have some sort of extension on them so the ones exposed to the host can be without a dot?

ergonlogic commented 9 years ago

This should already be blocked in the UI (in the 0.3.x branch), with the introduction of the 'hosting_valkyrie' module. We'll need to also block such site names in the CLI.

I'd hesitate to try and alter the alias names in the VM, since this is core Aegir behaviour, and will likely result in a number of unintended side-effects.