search

GetValkyrie / valkyrie

Valkyrie is an opinionated local dev stack that makes features/git based Drupal development easy.
http://www.getvalkyrie.com
GNU General Public License v3.0
45 stars 11 forks source link

Proposed solution for Issue #22 App upgrade/update command #52

Closed RealLukeMartin closed 9 years ago

RealLukeMartin commented 9 years ago

Update global Valkyrie and it's submodules with a drush valkyrie-upgrade or drush vug

RealLukeMartin commented 9 years ago

Good to know there is a way to show output with drush_shell_exec() now, I went with drush_shell_proc_open() primarily because I saw the output out of the box, but going to switch that back now that I know about drush_get_option().

I first tried out the drush_shell_cd_and_exec() but was having issues with git recognizing the working tree, although with the changes you suggested about not going the git route and more the valkyrie project I think that won't be a problem.

I'll make those changes, remove the submodule mentions and send another PR when I have all that set up.

ergonlogic commented 9 years ago

Actually, what I mean was not to show the output of git pull unless the user specified --debug. to get output from drush_shell_exec(), use drush_shell_exec_output(), iirc.

RealLukeMartin commented 9 years ago

Cool I go with it as an option. For testing, the output helped a lot, but not really that necessary for the average user unless they really want to see it .