Geta / Tags

Geta Tags for EPiServer CMS
Apache License 2.0
20 stars 33 forks source link

Tags not saved/updated #11

Closed christian-rosberg closed 10 years ago

christian-rosberg commented 10 years ago

Using the Geta.Tags plugin 1.0.1 from Nuget on a EPiServer 7.5 site but having some issues where the tags aren't updated on a save/publish of the page. Typically this happens if you edit an existing page and remove existing tags (either but clicking the X on the tag/s or use backspace in the edit field to remove tags) and then add some new tags.

Ocassionally I have also noticed that it also happens that adding new tags don't trigger the Publish command even after moving to another text input, seems to be related to the issue above.

Using Google Chrome Version 37.0.2062.94 m on Windows 8.1.

regnars commented 10 years ago

Just added the nuget package Geta.Tags version 1.0.1 to an almost clean EPiServer site that is using EPiServer.Core, EPiServer.Core.CMS, EPiServer.Framework nuget packages version 7.7.1 and EPiServer.CMS.UI, EPiServer.CMS.UI.Core nuget packages version 7.8.2 . Tags are saved both on save and publish events of EPiServer. The publish command gets triggered every time as well.

Taking in account that Geta.Tags use the built in EPiServer functionality (it is simply extendind the EPiServer's textbox with a Dojo module), I assume that it has something to do with the version of EPiServer's nuget packages you are using. That said - what is the version of EPiServer's installed nuget packages that you are using?

regnars commented 10 years ago

And another question regarding this topic - do you have any javascript errors on your page?

christian-rosberg commented 10 years ago

In the project where we used Geta.Tags and got this problem we actually removed all editing/front-end parts and changed the model to use a PropertyStringList (used in Alloy) instead - just keeping the backend functionality of Geta.Tags.

Today I created a new Alloy site from EPiServer Nuget feed and updated the EPiServer packages to latest version (7.14). Added Geta.Tags Nuget package 1.0.1 and added a property to StandardPage like below:

[UIHint("Tags")] public virtual string Tags { get; set; }

After repeated updates of the tags for one of the standard pages the issue was still present, i.e. after adding tags, saving, removing tags, adding them again the changes didn't trigger the Publish action and the tags weren't saved on publish (triggered by another change). No JavaScript errors present.

In the attached screenshot I have added Tag1 and Tag3 (previously used tags) and they don't trigger publish action and weren't saved.

image

regnars commented 10 years ago

Just created a new Alloy web site, updated all EPiServer's packages to version 7.14.0 Added Geta.Tags version 1.0.1 to the project, added Tags property to the StandardPage.cs but still no luck reproducing the bug. Could you share the code for that Alloy website you've created?

christian-rosberg commented 10 years ago

Available here https://www.dropbox.com/s/31xbtqn0n7vyuxl/EPiServerTestSite.zip?dl=0 (packages removed so you need to use automatic restore of Nuget packages).

Note that the issue doesn't reproduce everytime so you'll need to edit, remove tags (previously used for this page), update, go back edit some times (I haven't understood exactly when the issue appears - only that it does sometimes when you add/update tags).

regnars commented 10 years ago

Got your code. Tested it numerous times in "About us" page by adding new tags, removing them, going back and forth from that page to another while saving didn't take place. Nothing seems to reproduce the bug. Anyways I think it might have something to do with the Dojo module, how EPiServer saves editorial page data and the exact steps you do that make this problem appear. As long as I don't have a precise scenario of this bug I'm afraid I can't help you. :(

christian-rosberg commented 10 years ago

Actually a collegue of mine had similiar issues with another component in EPiServer admin mode today - just like the one described here, indicating that there is some generic issue regarding the Dojo implementation within EPiServer admin (as you indicate) that somehow affects the data model in the client's browser. Closing since this issue most likely depends on EPiServer components. Thanks anyway.

regnars commented 10 years ago

No problem.