search

Geta / geta-notfoundhandler

The popular NotFound handler for ASP.NET Core and Optimizely, enabling better control over your 404 page in addition to allowing redirects for old URLs that no longer works.
Apache License 2.0
20 stars 16 forks source link

Ignore suggestions based on previously ignored #82

Closed ellinge closed 2 weeks ago

ellinge commented 1 year ago

Fixes #37

Now suggestions are not added if a matching ignore is found.

Also rewrote the buffering of 404 to allow logging if threshold has passed as well. Meaning the buffer can be less than buffersize before being processed. Seems logical to me but perhaps there's a reason for waiting to fill the buffersize always.

ellinge commented 1 year ago

@marisks shouln't logEvents.Count be used instead of bufferSize in check of threshold as well?

Here I mean: https://github.com/Geta/geta-notfoundhandler/blob/3d68a8d7ac530a91fb9b66e05a55429ec9dd3ec8/src/Geta.NotFoundHandler/Core/Suggestions/RequestLogger.cs#L68

marisks commented 1 year ago

We are working on rewriting the whole logging logic for Suggestions. This PR will be out of date soon.

ellinge commented 1 year ago

How soon? It would be nice to avoid getting a lot of suggestions already ignored.

jevgenijsp commented 2 weeks ago

Closing this issue, due to the fix was provided here: https://github.com/Geta/geta-notfoundhandler/pull/134