Geta / geta-optimizely-categories

An alternative to Optimizely's default category functionality, where categories are instead stored as localizable IContent.
5 stars 10 forks source link

Media folder "For this" shows with handlebars when on a category. #14

Open GeekInTheNorth opened 2 years ago

GeekInTheNorth commented 2 years ago

How to Reproduce:

  1. Go into the CMS Editor interface
  2. In the media pane, select the categories tab
  3. Click on any category to edit it
  4. Click on the media pane as if to choose an image to attach to the categories

Expected Behaviour: "For this..." shows as "For this category" (or equivalent)

Actual Behaviour: "For this..." shows as "For this {0}"

image

RobBlask commented 2 years ago

Any action on this issue?

OptimizelyPrime commented 11 months ago

as a stop-gap measure, you can add an xml file to your lang folder with the following:

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<languages>
  <language name="English" id="en">
    <contenttypes>
      <CategoryData>
        <name>Category</name>
      </CategoryData>
    </contenttypes>
  </language>
</languages>

opti will be able to pick it up there an put the token from the name node in there. whatever you want it to be

nhamlin-prft commented 11 months ago

It appears the package has lang/geta.epicategories.xml with the right structure, but that XML isn't being picked up after installing the package. If you add that raw file to the website's lang folder then the labels show up correctly. This could be added to the readme file in the installation instructions.

Note 1: This is how the sandbox does it. The XML was copied into the sandbox/Foundation/src/Foundation/lang folder. Note 2: This also affects the Blocks tab.