Display and functionality issues in quick edit

Geta / geta-optimizely-genericlinks

An extensive alternative to LinkItemCollection in Optimizely.

Apache License 2.0

4 stars 0 forks source link

Display and functionality issues in quick edit #13

Closed benmurphycb closed 1 year ago

benmurphycb commented 1 year ago

Hello,

When a block has a generic link property, the display is not working correctly in the quick edit dialog.

I think this just needs the main box having a width of calc(100% - 42px).

Functionality: It seems that the link is added correctly, but when clicking the 3 dots to edit again, the data is missing.

svenrog commented 1 year ago

I've had a look and found the source issue, _setValueAttr is called before postCreate in GenericItemEditor. Logic didn't handle initialization properly and this left the markup for the label empty. I've adjusted this in version 1.4.5 (submitted to the Optimizely nuget feed). Test it out and see if it solves the issue for you.

svenrog commented 1 year ago

Closed due to inactivity.